Add tool to identify tablets that need compaction#3650
Open
tom-vt4 wants to merge 11 commits into
Open
Conversation
ivakegg
reviewed
Jul 1, 2026
Collaborator
|
In general this looks really good. I only had one comment in there. For extra credit I would like for this tool to optionally (based on a parameter) actually kick off the compactions. |
tom-vt4
force-pushed
the
task/tabletExtentTool
branch
from
July 6, 2026 16:11
b2efc96 to
8558761
Compare
Add a utility tool that is able to identify tablets that need compaction. This tool is hosted in the project check-tablet-extents and can be built as an executable JAR. Closes #3581
lbschanno
force-pushed
the
task/tabletExtentTool
branch
from
July 6, 2026 16:13
8558761 to
a7686ad
Compare
dlmarion
reviewed
Jul 6, 2026
-Add main method back to allow usage of the tool with java -cp -Update README for usage of tool with accumulo command -Fix dependency issues
dlmarion
reviewed
Jul 7, 2026
lbschanno
requested changes
Jul 7, 2026
-Replace AccumuloClient usage with ServerContext -Test class requires refactoring for ServerContext -Removed create-shade-jar profile to use regular jar
-Use ClientContext instead of ServerContext to allow test suite to create MiniAccumuloCluster for testing -Refactor original checkTablets() to findCompactableTablets() to handle extent tracking -Add new checkTablets() method to handle tool output and parameter based compaction -Update documentation -Update error logging
lbschanno
requested changes
Jul 10, 2026
Collaborator
|
Overall looks pretty good. Made a couple suggestions. |
-This parameter isn't required if accumulo.properties is on classpath
ivakegg
reviewed
Jul 10, 2026
-Debug parameter controls tablet extent logging -Removed redundant dependencies in pom.xml
lbschanno
requested changes
Jul 17, 2026
| return false; | ||
| } | ||
|
|
||
| public static void checkTablets(ClientContext context, String tableName, Text begin, Text end, boolean mergeExtents, boolean compactTablets, boolean debug) |
Collaborator
There was a problem hiding this comment.
Similar not here about making the argument list simpler by passing in the Opts instance.
| * @throws IOException | ||
| * if an error occurs while reading the client properties file | ||
| */ | ||
| static List<Pair<Text,Text>> findCompactableTablets(ClientContext context, String tableName, Text begin, Text end, boolean mergeExtents, boolean debug) |
Collaborator
There was a problem hiding this comment.
We're starting to pass a fair number of arguments to this method now. It would be simpler to just pass in the Opts instance as an argument, and fetch the appropriate information from it.
| * if an error occurs while reading the client properties file | ||
| */ | ||
| @Override | ||
| public void execute(String[] args) throws AccumuloException, TableNotFoundException, IOException, AccumuloSecurityException { |
Collaborator
There was a problem hiding this comment.
I would like to see the functions ordered a bit differently here. I'd like to see them in the following order:
- main
- execute
- checkTablets
- formatArg
This allows for a more natural progression of understanding the logic flow when reading over the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a utility tool that is able to identify tablets that need compaction. This tool is hosted in the project check-tablet-extents and can be built as an executable JAR.
Closes #3581